fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18863 )
Change subject: scheduler: Add rate_ctr informing about not Dl block not found ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/18863/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/18863/1//COMMIT_MSG@7 PS1, Line 7: not Dl block not found no no no, double negation is in Russian, but not in English! ;) Maybe rather "... no DL block found"? P.S. In Russian it's normal to say "I have not found nothing", and this means "I found nothing". https://gerrit.osmocom.org/c/osmo-bts/+/18863/1/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/18863/1/src/common/scheduler.c@575 PS1, Line 575: Downlink frame not found while scheduling Maybe "No Downlink frame found for scheduling"? https://gerrit.osmocom.org/c/osmo-bts/+/18863/1/src/common/scheduler.c@704 PS1, Line 704: goto not_found; Just do 'break' here, rather than making the code even more "assemblish". -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I456d0cfbef1e03b147ce7d968a3ec42dd728fe74 Gerrit-Change-Number: 18863 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jun 2020 18:37:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
