neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18767 )
Change subject: vty: add 'mscpool roundrobin next' for ttcn3 tests ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18767/6/src/osmo-bsc/osmo_bsc_vty.c File src/osmo-bsc/osmo_bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18767/6/src/osmo-bsc/osmo_bsc_vty.c@942 PS6, Line 942: DEFUN(mscpool_roundrobin_next, mscpool_roundrobin_next_cmd, > maybe make that a hidden command with DEFUN_HIDDEN ? It's not something a > normal user should ever us […] Then again, if sysadmins would like to test a specific MSC, maybe it is useful to know that this command exists? (I've got the 'HIDDEN' patch set ready to submit, but now reconsidering) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2155d906505a26744966f442ffb1e87a6a9b494c Gerrit-Change-Number: 18767 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jun 2020 21:54:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
