laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19076 )
Change subject: pcu: Support sending with CS other than CS1 in f_ms_tx_ul_block() ...................................................................... Patch Set 2: > I thought about it and I don't think it makes much sense in the context of > GPRS, since the message itself doesn't contain information about the CS it > uses, since that's done at a lower layer and we don't reach that point, we > simply encode based on block size. Also I don't see the point in transmitting > in for instance CS3 if the LLC block you want to transmit fits in a CS1. It does't make sense in a practical use case (i.e. an actual production implementation). However, in a test tool, I think it does make sense to be able to express such unusual (but legal!) situations. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibafa4246b442e7c26666eb0d37570bfbbf1dbda7 Gerrit-Change-Number: 19076 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Thu, 02 Jul 2020 08:50:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
