fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062 )
Change subject: bsc: verify System Information presence on RSL startup ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062/2/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062/2/bsc/BSC_Tests.ttcn@640 PS2, Line 640: deactivate > I'm not familiar with the details of SI during OML/RSL startup, […] An important thing that should be noted first is that the OML link and the RSL link(s) are separate TCP/IP connections. The OML link is established first, then the BSC configures all transceivers and timeslots, and after that the BSC indicates remote IP/port for the RSL link(s). All System Information messages are sent over the RSL link of C0. A BTS is considered "connected" when all its OML Managed Objects are "UNLOCKED", and all its transceivers have established the RSL connections. See all_trx_rsl_connected_unlocked(). I guess it works fine for you because we have TCP_NODELAY in the recent libosmo-abis. There is still a chance that not all System Information messages would arrive when f_wait_oml() returns and as_catch_RSL_sysinfo() gets deactivated. This would result in sporadic test case failures. The simplest, not elegant solution would be to call f_sleep(1.0) before deactivating as_catch_RSL_sysinfo(). The proper (IMO) solution would be to have a list of expected (not empty) System Information messages somewhere in the module parameters (in accordance with osmo-bsc.cfg), so you know what you're waiting for in the 'alt' statement, 'repeat' unless all expected kinds of SI are received, and fail if a timer expires. I am now also wondering whether we really need to expect/collect/check the SI messages here and thus in every test case, or exclusively in those ones that actually aimed to verify the SI. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a8ef404087efee491390dc1d2452ac323f145f0 Gerrit-Change-Number: 19062 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sat, 04 Jul 2020 13:00:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment
