pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19196 )
Change subject: pdch.cpp: Fix wrong annoying log line about non-scheduled ResourceReq received ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/19196/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/19196/1/src/pdch.cpp@574 PS1, Line 574: "MS requests UL TBF in PACKET RESOURCE REQ of " > (seems odd to trivially tweak the log message to uppercase; in the test log > other logging still prin […] Uppercase is already used in other log lines in this file, and it matches what wireshark uses, as well as making it easier to understand it's a packet type and not some description. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4b4367126d6a16055cd2f45afc4a6b9c15a7c980 Gerrit-Change-Number: 19196 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 09 Jul 2020 11:40:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment
