laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19372 )
Change subject: libomsocoding: NEON viterbi acceleration ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19372/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/19372/1//COMMIT_MSG@11 PS1, Line 11: Although autodetection according to __ARM_NEON would work because this : is only defined if the fpu is neon neon-fp16 neon-vfpv3 eon-vfpv4 : neon-fp-armv8 crypto-neon-fp-armv8 doing that would lead to a unknown : performance impact, so it needs to be enabled manually. > SS(S)E/AVX is a cpu feature set that differs depending on bits provided by > the cpu in a reg (and the […] thanks for explaining the Cortex-A8 situation. It probably deserves to be mentioned here as a concrete example why we don't enable it by default. After that explanation, I'm happy with your patch (minus the copyright notice). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I58ff2cb4ce3514f43390ff0a2121f81e6a4983b5 Gerrit-Change-Number: 19372 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jul 2020 12:52:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: Hoernchen <ew...@sysmocom.de> Gerrit-MessageType: comment
