pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19372 )
Change subject: libomsocoding: NEON viterbi acceleration ...................................................................... Patch Set 3: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/19372/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/19372/3//COMMIT_MSG@14 PS3, Line 14: performance impact, so it needs to be enabled manually. Please put in here the cortex-a8 situation like Harald suggested https://gerrit.osmocom.org/c/libosmocore/+/19372/3/src/conv_acc.c File src/conv_acc.c: https://gerrit.osmocom.org/c/libosmocore/+/19372/3/src/conv_acc.c@557 PS3, Line 557: dec->metric_func = osmo_conv_metrics_k5_n2; wrong indentation not addressed. https://gerrit.osmocom.org/c/libosmocore/+/19372/1/src/conv_acc_neon_impl.h File src/conv_acc_neon_impl.h: https://gerrit.osmocom.org/c/libosmocore/+/19372/1/src/conv_acc_neon_impl.h@26 PS1, Line 26: /* Some distributions (notably Alpine Linux) for some strange reason > This is a copy from the sse files and I see no reason to question this or > waste time tracking it dow […] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I58ff2cb4ce3514f43390ff0a2121f81e6a4983b5 Gerrit-Change-Number: 19372 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jul 2020 14:26:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: Hoernchen <ew...@sysmocom.de> Gerrit-MessageType: comment