Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19372 )
Change subject: libomsocoding: NEON viterbi acceleration ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19372/3/src/conv_acc.c File src/conv_acc.c: https://gerrit.osmocom.org/c/libosmocore/+/19372/3/src/conv_acc.c@557 PS3, Line 557: dec->metric_func = osmo_conv_metrics_k5_n2; > wrong indentation not addressed. it is not wrong, it is the reasonable approach here because your proposed "fix" suddenly introduces a new scope around the assignment in case NEON is not defined which clearly is not a preferrable choice just to make something "look nice" because it actually impacts the code itself and not merely cosmetic things -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I58ff2cb4ce3514f43390ff0a2121f81e6a4983b5 Gerrit-Change-Number: 19372 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jul 2020 14:35:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment