pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19140 )
Change subject: osmo_sock_init2: improve support for AF_UNSPEC ...................................................................... Patch Set 7: (1 comment) If I'm wrong please if possible improve that comment. https://gerrit.osmocom.org/c/libosmocore/+/19140/7/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19140/7/src/socket.c@386 PS7, Line 386: /* When called with AF_UNSPEC, family will set to IPv4 or IPv6 */ I think I don't get this comment + if clause. IIUC ig family=AF_UNSPEC is passed, no result in rp will match AF_UNSPEC; because all will be either AF_INET or AF_INET6. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I397c633931fd00d4f083955a3c49a40fb002d766 Gerrit-Change-Number: 19140 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jul 2020 11:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
