lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19143 )
Change subject: socket: introduce osmo_sock_init3 & osmo_sock_init3_ofd ...................................................................... Patch Set 11: (5 comments) https://gerrit.osmocom.org/c/libosmocore/+/19143/2/include/osmocom/core/socket.h File include/osmocom/core/socket.h: https://gerrit.osmocom.org/c/libosmocore/+/19143/2/include/osmocom/core/socket.h@69 PS2, Line 69: int osmo_sock_init3(uint16_t type, uint8_t proto, > Looks like it'd be better keeping current order. Move osmo_sock_init3 above > and leave the _ofd here. Done https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@448 PS2, Line 448: #define OSMO_SOCKADDR_TO_STR(sockaddr) \ > Ack Done https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@451 PS2, Line 451: strcpy(sastr.ip, "Invalid IP") > Ack Done https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@453 PS2, Line 453: int osmo_sock_init3(uint16_t type, uint8_t proto, > Ack Done https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@931 PS2, Line 931: return osmo_fd_init_ofd(ofd, osmo_sock_init3(type, proto, local, remote, flags)); > It's not a problem, if osmo_sock_init3() fails, osmo_fd_init_ofd() will > return immediately. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1eece543e3241ef0e095eb63bb831f7c15a16794 Gerrit-Change-Number: 19143 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sat, 01 Aug 2020 20:15:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
