laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19141 )
Change subject: socket.h: introduce osmo_sockaddr to hold v4 and v6 endpoints ...................................................................... Patch Set 8: > While looking into socket.h, if EMBEDDED it doesn't include <arpa/inet.h>. > But should be socket.h used at all on EMBEDDED? no, there are no sockets on arm-none-eabi bare-iron embedded targets. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If80172373735193401af872b18e1ff00c93880e7 Gerrit-Change-Number: 19141 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2020 10:59:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment