laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 )
Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG ...................................................................... Patch Set 7: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19146/6/src/gsm/abis_nm.c File src/gsm/abis_nm.c: https://gerrit.osmocom.org/c/libosmocore/+/19146/6/src/gsm/abis_nm.c@515 PS6, Line 515: NM_ATT_OSMO_NS_LINK_CFG > Shouldn't this be a part of abis_nm_osmo_att_tlvdef? At least > NM_ATT_OSMO_REDUCEPOWER is defined the […] see my comment https://gerrit.osmocom.org/c/libosmocore/+/19146#message-613e3f74ae329e8cf29b825cd7cac017631dd3f3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Thu, 06 Aug 2020 16:41:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
