laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/19310 )
Change subject: encoding: assert() presence of Downlink TBF
......................................................................
encoding: assert() presence of Downlink TBF
This is not something that should normally happen. If it happens,
then it's definitely a bug, and we should not tolerate it.
Change-Id: I6e46ba42650f0db2399649b536a1d2b3f0fcbf04
---
M src/encoding.cpp
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/encoding.cpp b/src/encoding.cpp
index 2564575..9dfd7c9 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -494,10 +494,7 @@
/* 3GPP TS 44.018 ยง10.5.2.16 IA Rest Octets */
dest->cur_bit = wp;
if (downlink) {
- if (!as_dl_tbf(tbf)) {
- LOGP(DRLCMACDL, LOGL_ERROR, "Cannot encode DL IMMEDIATE
ASSIGNMENT without TBF\n");
- return -EINVAL;
- }
+ OSMO_ASSERT(as_dl_tbf(tbf) != NULL);
rc = write_ia_rest_downlink(as_dl_tbf(tbf), dest, polling,
gsm48_ta_is_valid(ta), fn, alpha, gamma,
ta_idx);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19310
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6e46ba42650f0db2399649b536a1d2b3f0fcbf04
Gerrit-Change-Number: 19310
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
