fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/11410 )
Change subject: gsm_412 Cell Broadcast ...................................................................... Patch Set 9: Code-Review-1 (5 comments) CR-1 due to LE specific field order. https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h File include/osmocom/gsm/protocol/gsm_04_12.h: https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@48 PS9, Line 48: ?? What should be here? https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@56 PS9, Line 56: gsm412_warning_type This is only valid for little endian, please run 'libosmocore/contrib/struct_endianess.py'. https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@84 PS9, Line 84: gsm412_9_serial_nr Same here. https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@91 PS9, Line 91: gsm412_9_page_param And here. https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@114 PS9, Line 114: struct gsm412_ A missing structure or TODO? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/11410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1a17c2ae8bf62150327956c10cb5bb896939e3fd Gerrit-Change-Number: 11410 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Thu, 06 Aug 2020 17:55:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
