laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/19553 )
Change subject: vty: allow enabling freq. hopping regardless of the feature
vector
......................................................................
vty: allow enabling freq. hopping regardless of the feature vector
The hard-coded per-BTS feature vector for osmo-bts currently lacks
BTS_FEAT_HOPPING, and this is unlikely to change, because only the
recent osmo-bts-trx does support freq. hopping, while the other
(DSP based) back-ends do not seem to be capable of doing it.
Let's allow enabling freq. hopping regardless of the feature vector,
so either it would work if it's supported, or the BTS would reject
Set Channel Attributes message by sending NACK on the A-bis/OML.
Change-Id: Iff23109cacb5d314f7bcbf34b25e89af9281ce40
Related: SYS#4868, OS#4546
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 16935d3..9bb650f 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4588,9 +4588,10 @@
int enabled = atoi(argv[0]);
if (enabled && !osmo_bts_has_feature(&ts->trx->bts->model->features,
BTS_FEAT_HOPPING)) {
- vty_out(vty, "%% BTS model does not support hopping%s",
- VTY_NEWLINE);
- return CMD_WARNING;
+ vty_out(vty, "%% BTS model does not seem to support freq.
hopping%s", VTY_NEWLINE);
+ /* Allow enabling frequency hopping anyway, because the BTS
might not have
+ * connected yet (thus not sent the feature vector), so we
cannot know for
+ * sure. Jet print a warning and let it go. */
}
ts->hopping.enabled = enabled;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19553
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iff23109cacb5d314f7bcbf34b25e89af9281ce40
Gerrit-Change-Number: 19553
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-MessageType: merged
