laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19568 )

Change subject: log: for VTY Unknown Command, fix weird log message
......................................................................

log: for VTY Unknown Command, fix weird log message

In f_vty_wait_for_prompt(), this:

   testcase.stop(fail, "VTY: Unknown Command")

outputs:

   failVTY: Unknown Command

The first stop() argument 'fail' is not actually a test verdict, but gets
rolled into a log output string, becoming "failVTY".

Fix that by simply using the normal pattern of setverdict() followed by
mtc.stop().

Change-Id: Id09986444de02c10b4fba582d454d54568b6e8a2
---
M library/Osmocom_VTY_Functions.ttcn
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/library/Osmocom_VTY_Functions.ttcn 
b/library/Osmocom_VTY_Functions.ttcn
index cb3434e..e5f615c 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -68,7 +68,8 @@
                        [] pt.receive(pattern "[\w-]+\(*\)\# ") { };
                        [] pt.receive(t_vty_unknown) {
                                if (strict) {
-                                       testcase.stop(fail, "VTY: Unknown 
Command");
+                                       setverdict(fail, "VTY: Unknown 
Command");
+                                       mtc.stop;
                                } else {
                                        log("VTY: Unknown Command (ignored)");
                                        buf := buf & rx;

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19568
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id09986444de02c10b4fba582d454d54568b6e8a2
Gerrit-Change-Number: 19568
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged

Reply via email to