pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19888 )
Change subject: mgcp_client: Allow submitting and parsing IPv6 addr in SDP ...................................................................... Patch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/19888/2/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19888/2/src/libosmo-mgcp-client/mgcp_client.c@a375 PS2, Line 375: if (st > I see, indeed the old function also didn't guard against that. […] I think that's clear in any C string. However, looking at it another time, I think there can be some issue with the extra checks I added in osmo_strlcpy, and later, since we are copying wahtever may be after the IP address. I think I should add more manual checks there, so please don't merge this one yet. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b Gerrit-Change-Number: 19888 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2020 11:53:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
