laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19792 )
Change subject: lchan_fsm: make rsl mode-modify working again ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/19792/1/src/osmo-bsc/lchan_fsm.c File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/19792/1/src/osmo-bsc/lchan_fsm.c@923 PS1, Line 923: lchan_rtp_fsm_start(lchan); > I thought of this yes, but I think this is not a real life scenario. […] I would suppose there are such situations, let's say you start a USSD command just after ending a call, i.e. after the CC transaction is cleared, but before the actual readio channel is gone. The same probably would go for MT-USSD sessions that are started during a voice call but continue after the call is over. Not the most common scenario, but definitely plausible. Also, in terms of RTP: What if another voice call is just coming in before the old lchan is released? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2c5a283b1ee33745cc1fcfcc09a0f9382224e2eb Gerrit-Change-Number: 19792 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Tue, 01 Sep 2020 15:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pma...@sysmocom.de> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment
