fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19787 )
Change subject: encoding: use CSN.1 codec to generate Packet Uplink Assignment ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/19787/2/src/encoding.cpp File src/encoding.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/19787/2/src/encoding.cpp@538 PS2, Line 538: /* generate uplink assignment */ > May be good idea documenting that "block" should be zero initialized by the > caller. Done, see also https://gerrit.osmocom.org/c/osmo-pcu/+/20014. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2850b91e0043cdca8ae7498a5fc727eeedd029b6 Gerrit-Change-Number: 19787 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 07 Sep 2020 19:48:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
