neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20356 )
Change subject: LCS: SCCP next conn id: prepare Lb-interface ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/include/osmocom/bsc/gsm_data.h@53 PS1, Line 53: struct osmo_sccp_instance; > huh, OpenBSD guys despise #include statements? ;) […] I can explain again: whenever you #include in a .h file, you pull in potential cascades of more #includes and "dependencies", you potentially enlarge the compilation unit for each .o file, and, more critically, you may inadvertently introduce circular includes that break compilation. So every .h file that avoids an #include by an opaque declaration helps reducing #include chains. It is the .c file's responsibility to #include those headers that are required for that compilation unit. (Another theoretical argument is that the .c file might want to use a different implementation of that opaque struct, but that doesn't happen in practice, at least nowhere i've been, because that'd be insane.) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I12fcb18f6e4380f72929cfe7681bac05330a8c9a Gerrit-Change-Number: 20356 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: Vadim Yanitskiy <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 07 Oct 2020 12:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: Vadim Yanitskiy <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
