neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 )
Change subject: LCS: implement the bulk of Location Services ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c File src/osmo-bsc/lcs_loc_req.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c@144 PS1, Line 144: // FIXME LCS QoS IE is mandatory for requesting the location > This probably needs to be addressed before merging? we don't require the IE, just we "should" be pedantic about accepting the message when that IE is missing. Not necessary to implement now. https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c@461 PS1, Line 461: int paging_request_cancel(struct bsc_subscr *bsub, enum bsc_paging_reason reasons) > unsigned you mean the return value? keeping the same rc as paging_request_stop() above. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 07 Oct 2020 12:24:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
