lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/20495 )
Change subject: oml: fix handling of NSVC local port in
oml_ipa_mo_set_attr_nsvc()
......................................................................
oml: fix handling of NSVC local port in oml_ipa_mo_set_attr_nsvc()
This is another regresion introduced by [1]. Both local and remote
port numbers recived in the network order, and must be stored as-is.
Change-Id: I3c21a2c27dcbf6de728ce2c7ccbae9e2f517c450
Fixes: I310699fabbfec4255f0474f31717f215c1201eca
Related: SYS#4915
---
M src/common/oml.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Vadim Yanitskiy: Looks good to me, approved
lynxis lazus: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/common/oml.c b/src/common/oml.c
index 5394e8a..2a87b03 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1272,7 +1272,7 @@
nsvc->remote.u.sin.sin_addr.s_addr = _cur_l;
cur += 4;
memcpy(&_cur_s, cur, 2);
- nsvc->local.u.sin.sin_port = ntohs(_cur_s);
+ nsvc->local.u.sin.sin_port = _cur_s;
}
if (TLVP_PRES_LEN(tp, NM_ATT_OSMO_NS_LINK_CFG, 10)) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20495
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3c21a2c27dcbf6de728ce2c7ccbae9e2f517c450
Gerrit-Change-Number: 20495
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
