Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20564 )
Change subject: add osmo_sockaddr_to_str_buf/osmo_sockaddr_to_str ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/20564/1/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/20564/1/src/socket.c@1725 PS1, Line 1725: 8 and +1 more for '\0'? https://gerrit.osmocom.org/c/libosmocore/+/20564/1/src/socket.c@1752 PS1, Line 1752: snprintf(buf + written, buf_len - written, ":%d", port); > %u Ack https://gerrit.osmocom.org/c/libosmocore/+/20564/1/src/socket.c@1764 PS1, Line 1764: snprintf(buf + 1 + written, buf_len - written - 1, "]:%d", port); > %u Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I917f25ebd1239eae5855d973ced15b93731e33a0 Gerrit-Change-Number: 20564 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 12 Oct 2020 10:05:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
