laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/20672 )

Change subject: emergency: set route-to-msisdn MSISDN to "emergency" by default.
......................................................................


Patch Set 3:

> Patch Set 3:
>
> > Patch Set 3:
> >
> > I don't think so, but keith says that osmo-sip-connector needs this MSISDN 
> > to act properly.
>
> Just to clarify that, It's not the the sip-connector NEEDS "emergency", it 
> will work fine with "112"
>
> I was pointing out that when the sip connector gets an emergency call with no 
> number (behaviour previous to this patch) - it will insert "emergency", after 
> this patch, that would not happen.
>
> But don't waste time on it - use "112"

so you are saying emergency calls were working prior to this patch, and 
osmo-sip-connector translated the MNCC Flag for emergency into an "emergency" 
SIP user ID or the like?  Then why do we need this patch?


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/20672
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8a600cef105c0d67a9991e14b2187e26eacb01ec
Gerrit-Change-Number: 20672
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <ke...@rhizomatica.org>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Oct 2020 17:48:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to