pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21040 )
Change subject: ns2: Send NSVC representation in NS_AFF_CAUSE_VC_* status indication ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21040/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/21040/1/src/gb/gprs_ns2.c@378 PS1, Line 378: nsp.u.status.nsvc = gprs_ns2_ll_str_c(nse, nsvc); looks like a stack buffer version of the function would fit better here, since you are only using the buffer in this function (freeing it at the end). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21040 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iad6f0dc4565a46868cbbe17c361dcd473006c83d Gerrit-Change-Number: 21040 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 04 Nov 2020 10:28:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
