fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21093 )
Change subject: pcu: Specify (M)CS to use when sending UL rlcmac data blocks ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21093/4/library/RLCMAC_Templates.ttcn File library/RLCMAC_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21093/4/library/RLCMAC_Templates.ttcn@42 PS4, Line 42: cs_mcs >= MCS_0 so this works fine? no need for enum2int? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21093/4/library/RLCMAC_Types.ttcn File library/RLCMAC_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21093/4/library/RLCMAC_Types.ttcn@119 PS4, Line 119: 2b inserted shifted :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I918acac81f550077daeda3374b3de9b426ff3572 Gerrit-Change-Number: 21093 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sun, 15 Nov 2020 08:39:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
