pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300 )
Change subject: Process: Add remote_port as new parameter ...................................................................... Patch Set 1: Code-Review-1 (6 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1//COMMIT_MSG@11 PS1, Line 11: ssh instances are running on a single mashine. machine https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/core/process.py File src/osmo_gsm_tester/core/process.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/core/process.py@408 PS1, Line 408: # If remote_port is set the command will be executed over ssh on the Android UE. Drop this comment https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/core/remote.py File src/osmo_gsm_tester/core/remote.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/core/remote.py@54 PS1, Line 54: def RemoteProcess(self, name, popen_args, remote_env={}, remote_port=None, **popen_kwargs): Rather move this remote_port to RemoteHost class above like the other parameters. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/obj/run_node.py File src/osmo_gsm_tester/obj/run_node.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/obj/run_node.py@40 PS1, Line 40: self._remote_port = remote_port ssh_port https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/obj/run_node.py@59 PS1, Line 59: conf.get('run_label', None), conf.get('remote_port', None)) ssh_port https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300/1/src/osmo_gsm_tester/obj/run_node.py@94 PS1, Line 94: def remote_port(self): ssh_port -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I2c93fd2ea1c10c333d00eafd3c1066c35796e398 Gerrit-Change-Number: 21300 Gerrit-PatchSet: 1 Gerrit-Owner: ninjab3s <nils.fuer...@softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 23 Nov 2020 19:45:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
