ninjab3s has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302 )
Change subject: Introduce Android UEs as new modems ...................................................................... Patch Set 2: (7 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2//COMMIT_MSG@32 PS2, Line 32: Infrastructure explaination: > You probably want to add all this documentarion into the UserManual too > (osmo-gsm-tester. […] Sure! My college Bedran is currently working on a detailed description. We will add it to the manual as well. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2//COMMIT_MSG@55 PS2, Line 55: dropbearmulti dropbear -F -E -p 130 -R -T /data/local/tmp/authorized_keys -U 0 -G 0 -N root -A > what's this dropbearmulti? Its a single binary version of dropbear. https://github.com/mkj/dropbear/blob/master/MULTI. We will explain this in the part to be added to the manual. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2//COMMIT_MSG@87 PS2, Line 87: ue_serial: '8d9d79a9' > what's this for? can you check if you can reuse any of the existing fields? > like "path" ? This is the USB serial of the device used by ADB to identify UEs. path is not used by the AndroidUE class, so it should be possible to reuse this variable here. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/src/osmo_gsm_tester/obj/bitrate_monitor.py File src/osmo_gsm_tester/obj/bitrate_monitor.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/src/osmo_gsm_tester/obj/bitrate_monitor.py@58 PS2, Line 58: self.rem_host.remote_user = 'root' > You should ideally use sudo with sudoers file limit use of certain commands, > that what we usually di […] Unfortunately sudo is not available under Android and we did not find a way to add users to the Android OS. For these reasons we used the workaround with setting remote_user to 'root'. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/src/osmo_gsm_tester/obj/bitrate_monitor.py@79 PS2, Line 79: self.testenv.remember_to_stop(self.rx_monitor_proc) > As I shared before, return run_androidue_cmd without calling launch() on it, > then AFTER calling reme […] I understand, I rework all occurrences in the upcoming patches. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/src/osmo_gsm_tester/obj/bitrate_monitor.py@88 PS2, Line 88: brate_rx_raw = self.rx_monitor_proc.get_stdout().split('\n') > if you run the process locally you may find out the output you are looking > for is in stderr, be care […] Ack https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/sysmocom/suites/4g/iperf3_dl.py File sysmocom/suites/4g/iperf3_dl.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/sysmocom/suites/4g/iperf3_dl.py@26 PS2, Line 26: proc = iperf3cli.prepare_test_proc(iperf3cli.DIR_DL, ue.netns(), bitrate=max_rate, ue=ue) > ue.path() instead of pasing ue? Or ue.serial_device()? […] In case an AndroidUE is used I need to know two values, the ADB serial of the UE for local execution and the ssh port for remote execution. Further, I have to distinguish between AndroidUE modems and all the others. To keep the number of changes low I suggest to add a new function to the base class which returns the appropriate value depending on local or remote execution. What do you think about this? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I79a5d803e869a868d4dac5e0d4c2feb38038dc5c Gerrit-Change-Number: 21302 Gerrit-PatchSet: 2 Gerrit-Owner: ninjab3s <nils.fuer...@softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 25 Nov 2020 11:35:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
