Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373 to look at the new patch set (#2). Change subject: bsc: add TC_assignment_codec_amr_startmode_cruft ...................................................................... bsc: add TC_assignment_codec_amr_startmode_cruft Make sure that when a 'start-mode auto' is set, that the previous start mode setting does not linger in the unused bits. - after I577ff590d7588fd7e3ee4846c7955ab8f84cf2b1, osmo-bsc sets its ICMI bit properly, but passes this test only because it *always* sends smod (start-mode) bits as zero. - in I49691df01745a7c485bf165e897872c35fc4b147, the smod bits are properly sent on RSL, but this test shows that when ICMI becomes zero for 'start-mode auto', the smod bits will remain whatever start-mode was set in the previous osmo-bsc config. Instead, osmo-bsc should clear the smod bits for 'start-mode auto' so that its MultiRate Config does not vary depending on what was previously configured. - in I1ec5bad0bce01cc425ee05ecf70c83ec662a226a, clearing smod is implemented and this test is expected to pass. Change-Id: I151678f64e680f30f35b6bb2b0036d63efde9f2c --- M bsc/BSC_Tests.ttcn 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/21373/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I151678f64e680f30f35b6bb2b0036d63efde9f2c Gerrit-Change-Number: 21373 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-MessageType: newpatchset