pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/21239 )
Change subject: common: Introduce OSMOCOM_REPO_MIRROR param ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/docker-playground/+/21239/1/osmo-nitb-master/Dockerfile File osmo-nitb-master/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/21239/1/osmo-nitb-master/Dockerfile@6 PS1, Line 6: ARG DISTRO > Here you do (as well as in some other cases) […] I would say it doesn't really matter if it's added or not here if it's not used later on, I see points for and against for both. I'd say it's fine keeping it here if not used in case somebody wants to use it here in the future. Feel free to say if you really want it in a specific way and i change it, otherwsise I say let's merge as it is. As you see it's tons of files so it's expected that some file may be a bit different than others. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/21239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8010b08f3dabacfb3c13a44eece6c7a490e0742e Gerrit-Change-Number: 21239 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 01 Dec 2020 11:32:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillm...@sysmocom.de> Gerrit-MessageType: comment
