laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21423 )
Change subject: Store GPRS MOs directly under BTS SiteMgr object ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/21423/1/include/osmocom/bsc/bts.h File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/21423/1/include/osmocom/bsc/bts.h@a362 PS1, Line 362: struct { : struct gsm_abis_mo mo; : uint16_t bvci; : uint8_t timer[11]; : struct gprs_rlc_cfg rlc_cfg; : } cell; the "cell" could actually stay here, as there is always exactly one per BTS. https://gerrit.osmocom.org/c/osmo-bsc/+/21423/1/include/osmocom/bsc/bts_sm.h File include/osmocom/bsc/bts_sm.h: https://gerrit.osmocom.org/c/osmo-bsc/+/21423/1/include/osmocom/bsc/bts_sm.h@69 PS1, Line 69: struct this one is per BTS, isn't it? One Cell == One BTS -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I06461b7784fa2a78de37383406e35beae85fbad8 Gerrit-Change-Number: 21423 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Tue, 01 Dec 2020 19:32:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
