laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21441 )
Change subject: power_control: generalize power control state structure ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/21441/1/include/osmo-bts/gsm_data.h File include/osmo-bts/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bts/+/21441/1/include/osmo-bts/gsm_data.h@165 PS1, Line 165: uint8_t current; : uint8_t max; : bool fixed; units ? - ah I see you're just moving. Would still be worth afollow-up patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8c6ad8d14349e8a05084c2912644c5202f951f52 Gerrit-Change-Number: 21441 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Tue, 01 Dec 2020 19:41:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
