fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21450 )
Change subject: vty: fix dump_lchan_trx_ts(): dump dedicated channels only ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/21450/1/src/common/vty.c File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/21450/1/src/common/vty.c@1408 PS1, Line 1408: swi > you are comparing lchan->state with constants for lchan->type? Indeed, this is wrong. Quick & 'safe' if() -> switch() change before pushing to Gerrit... Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id7880de56a93cc9fa4ca576b094cef35ee269822 Gerrit-Change-Number: 21450 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 02 Dec 2020 21:23:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment