neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21510 )
Change subject: log reserved resources ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21510/2/selftest/suite_test/suite_test.ok File selftest/suite_test/suite_test.ok: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21510/2/selftest/suite_test/suite_test.ok@148 PS2, Line 148: tst test_suite: RESERVED RESOURCES for test_suite: > So what's the point? you already see the same output above ^ […] Looks like we can indeed drop the below DBG one, but these few lines on the normal log are very useful: I added this because looking at a running non-dbg log output (I think in jenkins console) it was completely invisible which cells were being picked in a test run, and I found that intolerable. Which cell a test is actually running on is the most fundamental thing I want to know about a test. I look for this info very frequently and now can find it very easily. I added the full dicts on DBG without thinking about it, but the part i actually need is the brief part in the non-dbg log. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21510/2/selftest/suite_test/suite_test.ok@158 PS2, Line 158: tst test_suite: DBG: reserved resources for test_suite: we can drop this DBG one. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic23556eafee654c93d13c5ef405028da09bd51d7 Gerrit-Change-Number: 21510 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sun, 06 Dec 2020 22:17:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
