neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523 )
Change subject: add handover_2G suite, with handover.py test ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/handover-suites.conf File sysmocom/handover-suites.conf: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/handover-suites.conf@1 PS2, Line 1: - handover_2G:nanobts+bts1-oc2g > Why not adding it to the defaults-suites. […] happening in another commit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/suites/handover_2G/handover.py File sysmocom/suites/handover_2G/handover.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/suites/handover_2G/handover.py@91 PS2, Line 91: with bsc.ctrl() as bsc_ctrl: > so basically you keep the object until the end of the test. […] the entire point of 'with' is that the CTRL socket is also closed again when the test is done, whatever the reason. Otherwise we may end up leaking open sockets en masse. What other way would you suggest? https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/suites/handover_2G/handover.py@118 PS2, Line 118: wait_no_raise(counters.changed, timeout=20) > try: wait() except: pass […] i think at first i just wanted some supplementary info of the counters and not fail on them if they didn't change, but wait() is sufficient indeed. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I0b2671304165a1aaae2b386af46fbd8b098e3bd8 Gerrit-Change-Number: 21523 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sun, 06 Dec 2020 22:17:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
