pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21447 )
Change subject: power_control: implement BS (Downlink) Power Control ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/21447/5//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/21447/5//COMMIT_MSG@28 PS5, Line 28: trigger the logic to reduce the current attenuation twice. iirc from code you are /2, so this "reduce twice" actually means divide by two? https://gerrit.osmocom.org/c/osmo-bts/+/21447/5/src/common/power_control.c File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/21447/5/src/common/power_control.c@275 PS5, Line 275: state->current /= 2; here, /2. That's not "reduce twice" right? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5b509e71d5f668b6b8b2abf8053c27f2a7c78451 Gerrit-Change-Number: 21447 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 07 Dec 2020 13:45:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
