neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504 )
Change subject: add osmo_vty.py ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/1/src/osmo_gsm_tester/obj/osmo_vty.py File src/osmo_gsm_tester/obj/osmo_vty.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/1/src/osmo_gsm_tester/obj/osmo_vty.py@44 PS1, Line 44: def connect(self): > You sed you'd add but I don't see the comments with (PROTECTED, PUBLIC - > INTERNAL API, PUBLIC (test […] too many irons in the fire, forgot about this sorry. Actually i don't like those PROTECTED, PUBLIC... comments, but if it helps you then ok -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I7c17b143b7c690b8c4105ee7c6272670046fa91d Gerrit-Change-Number: 21504 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 07 Dec 2020 21:36:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment