laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21589 )
Change subject: ns2: Accept NS-UNBLOCK-ACK in UNBLOCKED state ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21589/1/src/gb/gprs_ns2_vc_fsm.c File src/gb/gprs_ns2_vc_fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/21589/1/src/gb/gprs_ns2_vc_fsm.c@403 PS1, Line 403: .in_event_mask = S(GPRS_NS2_EV_BLOCK) | S(GPRS_NS2_EV_UNBLOCK_ACK), > Only some of the lines are wrong, others are good, so I'm asking simply not > to make it worse * I don't think we have a general rule about not putting multiple in one line. Infact, IIRC all the orgiinal code I introduced was using multiple per line * whether it's "worse" is IMHO a question of taste It's OK to point out clear violations of [documented, established] coding style. However, pointing out something that is not a universal rule _and_ is not followed in the surrounding code is not OK for me, sorry. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icc4d960ddad82e3ebbf571d8ff9f24854b52a946 Gerrit-Change-Number: 21589 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 08 Dec 2020 12:20:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
