laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21607 )
Change subject: NM FSMs: fix DISABLED_NOTINSTALLED -> DISABLED_NOTINSTALLED ...................................................................... Patch Set 2: Code-Review+1 Wouldn't it make sense to handle this inside the macro/inline-functions? If you check inside nm_bb_transc_fsm_state_chg(), then you don't have to change the callers, and it would be a genric solution. In fact, we could even consider introducing an osmo_fsm flag that would make such transitions quiet for certain fsm "classes" that set the flag. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I24a78905bb684f8501dc5ade0605662ec283febc Gerrit-Change-Number: 21607 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 09 Dec 2020 16:12:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
