daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21598 )
Change subject: gb: Add beginnings of a new BSSGP implementation ...................................................................... Patch Set 6: Code-Review-1 (6 comments) https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/bssgp_bvc_fsm.c File src/gb/bssgp_bvc_fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/bssgp_bvc_fsm.c@4 PS6, Line 4: /* FIXME: This should probably be moved to libosmogb? */ Isn't it? Also license seems to be missing here https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/bssgp_bvc_fsm.c@238 PS6, Line 238: bfp->features.negotiated = bfp->features.advertised & features_rx; missing bfp->features.received = features_rx; https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/bssgp_bvc_fsm.c@650 PS6, Line 650: OSMO_ASSERT(bvci >= 2); OSMO_ASSERT(ra_id) as well https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/gprs_bssgp2.c File src/gb/gprs_bssgp2.c: https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/gprs_bssgp2.c@3 PS6, Line 3: License? https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/gprs_bssgp2.c@11 PS6, Line 11: //#include <osmocom/gprs/gprs_msgb.h> Remove https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/gprs_bssgp2.c@71 PS6, Line 71: BVC-BLOCK *BLOCK-ACK -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icbe8e4f03b68fd73b8eae95f6f6cccd4fa9af95a Gerrit-Change-Number: 21598 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 09 Dec 2020 16:13:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
