laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/21263 )
Change subject: Introduce osmo-ran docker image set up ...................................................................... Patch Set 6: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/docker-playground/+/21263/6/osmo-ran/Dockerfile File osmo-ran/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/21263/6/osmo-ran/Dockerfile@42 PS6, Line 42: less \ : apt-utils \ : strace \ : tcpdump \ : telnet \ : vim \ : osmo-bsc \ : osmo-bsc-ipaccess-utils \ : osmo-bts-trx \ : osmo-mgw \ : osmo-pcu \ : osmo-trx-ipc \ : osmo-trx-uhd && \ except of apt-utils the two lists seem identical. Might make sense to keep the common list of packages in some variable and then use it in both clauses? Not critical, but would IMHO increase maintainability and have less risk of breaking only either of the two at some later change. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/21263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If5d22e9fa818310cbb4adc34bd7aceb4416ec969 Gerrit-Change-Number: 21263 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Fri, 11 Dec 2020 10:07:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
