lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21573 )
Change subject: gprs_ns2_sns: rework IP-SNS initial remote ...................................................................... Patch Set 8: (4 comments) https://gerrit.osmocom.org/c/libosmocore/+/21573/2/src/gb/gprs_ns2_internal.h File src/gb/gprs_ns2_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/21573/2/src/gb/gprs_ns2_internal.h@296 PS2, Line 296: int offset); > offset means index here? Ack https://gerrit.osmocom.org/c/libosmocore/+/21573/2/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/21573/2/src/gb/gprs_ns2_sns.c@661 PS2, Line 661: /* empty state - SNS Select will start by all action */ > You mean ns2_sns_st_all_action()? Ack https://gerrit.osmocom.org/c/libosmocore/+/21573/2/src/gb/gprs_ns2_sns.c@1251 PS2, Line 1251: .in_event_mask = 0, > worth adding a comment saying events are handled in all_state. Ack https://gerrit.osmocom.org/c/libosmocore/+/21573/2/src/gb/gprs_ns2_sns.c@1338 PS2, Line 1338: else if (gss->initial->list.next == &gss->sns_endpoints) /* last entry, continue with first */ > keep using {} if first clause use {}. Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I71cdbfb53e361e6112fed5e2712236d797ef3ab2 Gerrit-Change-Number: 21573 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 14 Dec 2020 01:00:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
