laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21722 )
Change subject: gprs_bssgp: add handling for BSSGP RIM primitives ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/21722/2/include/osmocom/gprs/gprs_bssgp.h File include/osmocom/gprs/gprs_bssgp.h: https://gerrit.osmocom.org/c/libosmocore/+/21722/2/include/osmocom/gprs/gprs_bssgp.h@59 PS2, Line 59: PRIM_BSSGP_RIM, 3GPP TS 48.018 Section 5.3.37 + 5.3.38 calls this the RIM-PDU-TRANSFER (request / response) so it might make sense to also expand here to PRIM_BSSGP_RIM_PDU_TRANSFER. https://gerrit.osmocom.org/c/libosmocore/+/21722/2/include/osmocom/gprs/gprs_bssgp.h@188 PS2, Line 188: /* See also 3GPP TS 36.413, section 9.2.1.37 */ those changes should have gone to the previous patch I suppose? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idfd0a65872a2cc6089885afd8d31b0b029d85d47 Gerrit-Change-Number: 21722 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 16 Dec 2020 15:52:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
