rousseau has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sim-auth/+/20903 )
Change subject: SIM.py: convert to Python 3 using 2to3 ...................................................................... Patch Set 1: > Patch Set 1: Code-Review-1 > > we shouldn't introduce changes here, as this code is copied from > https://github.com/mitshell/card > > So any changes should go in upstream, and then we should either convert to > using mishell/card as a python module, or import it using git submodule, or > git subtree or the like. I reported the issue to https://github.com/mitshell/card/issues/7 But the problem is already fixed upstream. osmo-sim-auth uses a very old copy/fork of https://github.com/mitshell/card Maybe you should use a git submodule instead? -- To view, visit https://gerrit.osmocom.org/c/osmo-sim-auth/+/20903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sim-auth Gerrit-Branch: master Gerrit-Change-Id: I1f972e308e14dbdbfc85892685682220a89f77fe Gerrit-Change-Number: 20903 Gerrit-PatchSet: 1 Gerrit-Owner: rousseau <ludovic.rousseau+osmo...@free.fr> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Wed, 16 Dec 2020 16:30:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
