laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21750 )
Change subject: gprs_ns2: fr: fix crash when frame relay interface doesn't exists ...................................................................... gprs_ns2: fr: fix crash when frame relay interface doesn't exists When a frame relay interface doesn't exist gprs_ns2_fr_bind() would detect this but still return a success. Change-Id: I815b6ef5c3df780ac94461a05975a2b70898b01e --- M src/gb/gprs_ns2_fr.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c index 8147f66..fc6f166 100644 --- a/src/gb/gprs_ns2_fr.c +++ b/src/gb/gprs_ns2_fr.c @@ -514,8 +514,8 @@ fr_link->tx_cb_data = bind; priv->link = fr_link; - priv->ifindex = devname2ifindex(netif); - if (priv->ifindex < 0) { + priv->ifindex = rc = devname2ifindex(netif); + if (rc < 0) { LOGP(DLNS, LOGL_ERROR, "Can not get interface index for interface %s\n", netif); goto err_fr; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I815b6ef5c3df780ac94461a05975a2b70898b01e Gerrit-Change-Number: 21750 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-MessageType: merged