pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21787 )
Change subject: power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel ACTIVation ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21787/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21787/1/src/osmo-bsc/abis_rsl.c@516 PS1, Line 516: msgb_tlv_put(msg, tag, 0, NULL); > Not sure if I understand what you mean. […] TThe 2 switch cases above (nanobts, osmobts), are afaiu the same as the default one when calling a enc_power_rams as a NOOP, am I correct? So if we have an abstracted way to set the IE contents (enc_power_params func pointer), why do we want to have this switch case for osmobts and nanobts? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4 Gerrit-Change-Number: 21787 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 18 Dec 2020 17:00:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment