pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21787 )
Change subject: power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel
ACTIVation
......................................................................
Patch Set 1:
So I find the way you chose to structure abstraction a bit weird tbh. That
being said, I'm not going to block this, but I think it'd be less confusing if
for instance, you added a function pointer for "initial" setup and one for
"channel_act" setup of the IE, and implement that in each bts type.
Or for instance put the initial IE setup in the the ipacc_tx_..._def you are
adding in the last commit, and use the function pointer you add in this commit
as the "channel activ" one.
It's all even more confusing because you spread all this through different
commits. Just sharing my opinion in case you want to give it another thought.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4
Gerrit-Change-Number: 21787
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Dec 2020 17:51:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
