laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21788 )
Change subject: power_control: send default parameters from bootstrap_rsl() ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21788/2/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21788/2/src/osmo-bsc/osmo_bsc_main.c@344 PS2, Line 344: if (trx->bts->model->power_ctrl_send_def_params != NULL) { > I was thinking about that, but after looking at the code I realized that it's > not that easy. […] before/after SI: you could simply send the SI from inside that "rsl link comes up" function of each BTS model. trigger re-sending: The question is whether that entire operation is not way too specific. If we proceed like that we will at some point have dozens of 'trigger re-sending' VTY commands. I think we already have one for SI, now for power parameters, ... It could be one "resend everything we initialize at RSL start-up". Once again, not a strong requirement, just some thoughts. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I46ae4e6003a1839ee57f8e941a54bf479f7e532d Gerrit-Change-Number: 21788 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sun, 20 Dec 2020 15:48:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
