pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21792 )
Change subject: power_control: add encoding/init API to 'struct gsm_bts_model' ...................................................................... Patch Set 2: Code-Review+2 (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/21792/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/21792/2//COMMIT_MSG@11 PS2, Line 11: - power_ctrl_enc_rsl_params() - this function will be called by the I think you can see straightaway what differentiate both functions is when in the timeline the info is to be encoded, so I'd rather change these function pointers to be named something like: power_ctrl_enc_chan_act power_ctrl_enc_rsl_up https://gerrit.osmocom.org/c/osmo-bsc/+/21792/2/include/osmocom/bsc/bts.h File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/21792/2/include/osmocom/bsc/bts.h@187 PS2, Line 187: /* (Optional) function for encoding MS/BS Power Control paramaters */ I'd say in general try to add new fields structs in the same commit where you start using them (same with previous commit). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iba3ad5d8d549a6676050272f85b21c9b4c219d21 Gerrit-Change-Number: 21792 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 21 Dec 2020 09:45:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
