laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012 )
Change subject: CTRL: Introduce support to run osmocom CTRL server ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012/1/library/Osmocom_CTRL_Adapter.ttcn File library/Osmocom_CTRL_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012/1/library/Osmocom_CTRL_Adapter.ttcn@62 PS1, Line 62: v it might make sense to differentiate based on server/client in the ID. Othertwise you start both client and server "adapter" and their components have identical names. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I37db9962f51baf2c63bd58ec47ec89f773d7a255 Gerrit-Change-Number: 22012 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Thu, 07 Jan 2021 12:59:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment